Skip to content

{devel}[GCCcore/6.4.0] SQLite v3.19.3#4913

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
JackPerdue:20170719184758_new_pr_SQLite3193
Jul 21, 2017
Merged

{devel}[GCCcore/6.4.0] SQLite v3.19.3#4913
verdurin merged 2 commits intoeasybuilders:developfrom
JackPerdue:20170719184758_new_pr_SQLite3193

Conversation

@JackPerdue
Copy link
Copy Markdown
Contributor

@JackPerdue JackPerdue commented Jul 19, 2017

(created using eb --new-pr)
depends on PR#4907

@JackPerdue JackPerdue mentioned this pull request Jul 20, 2017
Closed
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 20, 2017

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/255473702

Only showing partial log for 1st failed test suite run 5442.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/255473703

...
FAIL: Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 1

----------------------------------------------------------------------
Ran 7365 tests in 335.007s

FAILED (failures=1)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

@JackPerdue
Copy link
Copy Markdown
Contributor Author

JackPerdue commented Jul 20, 2017

Depends on PR #4907 (trying to annotate for Github)

verdurin
verdurin requested changes Jul 20, 2017
View reviewed changes
easybuild/easyconfigs/s/SQLite/SQLite-3.19.3-GCCcore-6.4.0.eb Outdated
# eg. http://www.sqlite.org/2017/sqlite-autoconf-3190300.tar.gz
source_urls = ['http://www.sqlite.org/2017/']
version_str = '%%(version_major)s%s00' % ''.join('%02d' %
int(x) for x in version.split('.')[1:])
Copy link
Copy Markdown
Member

@verdurin verdurin Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this style error:

/home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/s/SQLite/SQLite-3.19.3-GCCcore-6.4.0.eb:28:15: E128 continuation line under-indented for visual indent

@JackPerdue JackPerdue mentioned this pull request Jul 20, 2017
Closed
@verdurin verdurin added this to the 3.4.0 milestone Jul 21, 2017
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 21, 2017

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
ca014.camp.thecrick.org - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2640 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b2aca8d19c4b8efe2a0f732e82c4f378 for a full test report.

@verdurin verdurin closed this Jul 21, 2017
@verdurin verdurin reopened this Jul 21, 2017
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 21, 2017

Looks good.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 21, 2017

Merging, thanks @JackPerdue

@verdurin verdurin merged commit 834b610 into easybuilders:develop Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JackPerdue @boegelbot @verdurin